574005 - Make obtaining CF_HTML directly work on Windows and Linux (application/x-moz-nativehtml)

Status: NEW

(Core :: DOM: Editor, defect)

Description

[(no longer active)]

See bug 572642 comment 15 through 25.

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: Patch for Make obtaining CF_HTML directly for Windows and Linux (application/x-moz-nativehtml)

Comment 2

[(no longer active)]

Comment on attachment 553884 [details] [diff] [review]
Patch for Make obtaining CF_HTML directly for Windows and Linux (application/x-moz-nativehtml)

Didn't know that this is going to be this easy! :)

Comment 3

[Brian R. Bondy [:bbondy]]

Thanks for the quick reviews :)

Comment 4

[(no longer active)]

How have you tested this patch?

Comment 5

[Brian R. Bondy [:bbondy]]

Only on Windows but I'll run it through the try server for sure once I get to this patch in my try-queue.

Comment 6

[(no longer active)]

(In reply to comment #5)
> Only on Windows but I'll run it through the try server for sure once I get to
> this patch in my try-queue.

No, I meant, what specifically have you tested on Windows?  With what target applications?

Comment 7

[Brian R. Bondy [:bbondy]]

I don't think this code is hit unless you specifically use application/x-moz-nativehtml.  

Normal copy/pasting of HTML gives you text/html. 

So the only way I know how to test this is via the mochitest.

Comment 8

[Brian R. Bondy [:bbondy]]

Ditto if you copy from Firefox and paste to a different program like Google Chrome it will go into CreateDataFromPrimitive with text/html.

Comment 9

[(no longer active)]

Well, land away then!  :-)

Comment 10

[(no longer active)]

This fell through the cracks too!

https://bug574005.bugzilla.mozilla.org/attachment.cgi?id=553884

Comment 11

[(no longer active)]

Erm, http://hg.mozilla.org/integration/mozilla-inbound/rev/b8d354d37128

Comment 12

[Brian R. Bondy [:bbondy]]

I think there was a problem with this on Linux still

Comment 13

[Ed Morley [:emorley]]

Caused linux M3 orange:
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-Inbound/1315868342.1315869595.15746.gz
{
11145 ERROR TEST-UNEXPECTED-FAIL | /tests/editor/libeditor/html/tests/test_CF_HTML_clipboard.html | Paste operation for cfhtml-firefox.txt should be successful in contenteditable - didn't expect -1, but got it
11146 ERROR TEST-UNEXPECTED-FAIL | /tests/editor/libeditor/html/tests/test_CF_HTML_clipboard.html | Paste operation for cfhtml-firefox.txt should be successful in designMode - didn't expect -1, but got it
11147 ERROR TEST-UNEXPECTED-FAIL | /tests/editor/libeditor/html/tests/test_CF_HTML_clipboard.html | Paste operation for cfhtml-ooo.txt should be successful in contenteditable - didn't expect -1, but got it
11148 ERROR TEST-UNEXPECTED-FAIL | /tests/editor/libeditor/html/tests/test_CF_HTML_clipboard.html | Paste operation for cfhtml-ooo.txt should be successful in designMode - didn't expect -1, but got it
11149 ERROR TEST-UNEXPECTED-FAIL | /tests/editor/libeditor/html/tests/test_CF_HTML_clipboard.html | Paste operation for cfhtml-ie.txt should be successful in contenteditable - didn't expect -1, but got it
11150 ERROR TEST-UNEXPECTED-FAIL | /tests/editor/libeditor/html/tests/test_CF_HTML_clipboard.html | Paste operation for cfhtml-ie.txt should be successful in designMode - didn't expect -1, but got it
11151 ERROR TEST-UNEXPECTED-FAIL | /tests/editor/libeditor/html/tests/test_CF_HTML_clipboard.html | Paste operation for cfhtml-chromium.txt should be successful in contenteditable - didn't expect -1, but got it
11152 ERROR TEST-UNEXPECTED-FAIL | /tests/editor/libeditor/html/tests/test_CF_HTML_clipboard.html | Paste operation for cfhtml-chromium.txt should be successful in designMode - didn't expect -1, but got it
}

Comment 14

[Brian R. Bondy [:bbondy]]

Actually I don't think there's a problem with the patch I just think we can only eanble Windows in test_CF_HTML_clipboard.html in the context of this ticket (Windows and Linux had the test disabled).  

I think I will be posting another ticket relating to whatever the second problem is on Linux.

Comment 15

[Ed Morley [:emorley]]

Backed out of inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/90a54cb7f985

Comment 16

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 17

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 18

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.